인프런 커뮤니티 질문&답변

자바와 관련된 것이라 조금 조심스럽긴 하지만, 해당 클래스를 아래와 같이 try-with-resources를 사용해 refactoring 해 보았습니다.
테스트 코드는 잘 돌아가는데, 아래와 같이 변경해도 상관없나해서 질문 남깁니다!

감사합니다!

package hello.jdbc.repository;

import hello.jdbc.connection.DBConnectionUtil;
import hello.jdbc.domain.Member;
import lombok.extern.slf4j.Slf4j;

import java.sql.*;
import java.util.NoSuchElementException;

/**
 * JDBC - DriverManager 사용
 */
@Slf4j
public class MemberRepositoryV0 {

    // jdbc를 이용해 member 객체 저장
    public Member save(Member member) throws SQLException {
        String sql = "insert into member(member_id, money) values (?,?)";

        try (Connection conn = getConnection();
             PreparedStatement pstmt = conn.prepareStatement(sql)) {
            pstmt.setString(1, member.getMemberId());
            pstmt.setInt(2, member.getMoney());
            pstmt.executeUpdate();
            return member;
        } catch (SQLException e) {
            log.error("db error", e);
            throw e;
        } catch (NullPointerException e) {
            log.info("NPE 발생", e);
        }
        return member;
    }

    public Member findById(String memberId) throws SQLException {
        String sql = "select * from member where member_id = ?";


        try (Connection conn = getConnection();
             PreparedStatement pstmt = createPreparedStatement(sql, conn, memberId);
             ResultSet rs = pstmt.executeQuery()) {
            if (rs.next()) {
                Member member = new Member();
                member.setMemberId(rs.getString("member_id"));
                member.setMoney(rs.getInt("money"));
                return member;
            } else {
                throw new NoSuchElementException("member not found memberId=" + memberId);
            }
        } catch (SQLException e) {
            log.error("db error", e);
            throw e;
        } catch (NullPointerException e) {
            log.info("NPE 발생", e);
        }
        return new Member();
    }

    private PreparedStatement createPreparedStatement(String sql, Connection conn, String memberId) throws SQLException {
        PreparedStatement pstmt = conn.prepareStatement(sql);
        pstmt.setString(1, memberId);
        return pstmt;
    }

    public void update(String memberId, int money) throws SQLException {
        String sql = "update member set money=? where member_id=?";
      
        try (Connection conn = getConnection();
             PreparedStatement pstmt = conn.prepareStatement(sql)) {
            pstmt.setInt(1, money);
            pstmt.setString(2, memberId);
            int resultSize = pstmt.executeUpdate();
            log.info("resultSize={}", resultSize);
        } catch (SQLException e) {
            log.error("db error", e);
            throw e;
        } catch (NullPointerException e) {
            log.info("NPE 발생", e);
        }
    }

    public void delete(String memberId) throws SQLException {
        String sql = "delete from member where member_id = ?";

        try (Connection connection = getConnection();
             PreparedStatement preparedStatement = connection.prepareStatement(sql)) {
            preparedStatement.setString(1, memberId);
            int resultSize = preparedStatement.executeUpdate();
            log.info("resultSize={}", resultSize);
        } catch (SQLException e) {
            log.error("db error", e);
            throw e;
        } catch (NullPointerException e) {
            log.info("NPE 발생", e);
        }
    }

    private static Connection getConnection() {
        return DBConnectionUtil.getConnection();
    }

}